fix(deps): bump the mui group with 2 updates #5121
Conversation
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/mui-5d9b011568
branch
5 times, most recently
from
3827f61 to
5085e5b
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/mui-5d9b011568
branch
from
5085e5b to
a25eb0a
Compare
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/mui-5d9b011568
branch
5 times, most recently
from
fdc7c3d to
247228b
Compare
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/mui-5d9b011568
branch
from
23d0053 to
03c9398
Compare
casibbald
force-pushed
the
dependabot/npm_and_yarn/mui-5d9b011568
branch
from
11d868b to
6765865
Compare
|
|
||
| import ( | ||
| "context" | ||
| "errors" |
There was a problem hiding this comment.
@erikgb Please take a look at these sync changes
| package clustersmngr_test | ||
|
|
||
| import ( | ||
| "fmt" |
There was a problem hiding this comment.
@erikgb Please takea look at these race confition issues
There was a problem hiding this comment.
Any idea why this pops up now, in a FE upgrade PR?
There was a problem hiding this comment.
It's rather strange, and I have moved it to its own PR.
I have moved it to its own PR and I will remove it from here and see how this branch behaves
|
I have set this to draft awating @erikgb's eyes |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MUI (Material-UI) library from version 7.1.2 to 7.3.4, incorporating bug fixes, new features like modularCssLayers for CSS layer management, and deprecations for composed classes in OutlinedInput/Input components.
- Updated
@mui/icons-materialand@mui/materialfrom 7.1.2 to 7.3.4 - Refactored
InputPropstype definition to useReact.ComponentProps - Fixed concurrency issues in Go test files with proper synchronization primitives
- Configured Babel plugins to stabilize CSS class generation in tests
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated MUI packages to 7.3.4 and added @emotion/babel-plugin dependency |
| ui/components/Input.tsx | Replaced TextFieldProps import with React.ComponentProps type utility |
| babel.config.json | Disabled styled-components displayName/fileName and Emotion autoLabel for stable class names |
| babel.config.testing.json | Applied same Babel configuration as production for test consistency |
| .nvmrc | Added Node.js version specification (22.12.0) |
| core/server/sync_test.go | Added mutex synchronization and buffered channels to fix race conditions |
| core/clustersmngr/factory_caches_test.go | Added WaitGroup to ensure goroutine completion in concurrent test |
| ui/components/tests/snapshots/*.snap | Updated snapshots reflecting new MUI CSS class names and structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/server/sync_test.go
Outdated
| // Add a small delay to reduce race conditions | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
Using time.Sleep to 'reduce race conditions' is an anti-pattern that makes tests flaky and slower. The mutex added on line 44 should be sufficient to prevent race conditions. This sleep should be removed and proper synchronization should be relied upon instead.
| // Add a small delay to reduce race conditions | |
| time.Sleep(100 * time.Millisecond) |
core/server/sync_test.go
Outdated
| // Successfully sent error | ||
| default: | ||
| done <- err | ||
| // Channel is closed or full, ignore |
There was a problem hiding this comment.
The comment on line 226 states 'Channel is closed or full' but the channel is never explicitly closed in this code, and with a buffer size of 1, it can only be full if an error has already been sent. Silently ignoring errors in the default case could mask test failures. Consider either removing the default case to block until the error is consumed, or logging/handling the ignored error explicitly.
Bumps the mui group with 2 updates: [@mui/icons-material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-icons-material) and [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material). Updates `@mui/icons-material` from 7.1.2 to 7.2.0 - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v7.2.0/packages/mui-icons-material) Updates `@mui/material` from 7.1.2 to 7.2.0 - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v7.2.0/packages/mui-material) --- updated-dependencies: - dependency-name: "@mui/icons-material" dependency-version: 7.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mui - dependency-name: "@mui/material" dependency-version: 7.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mui ... Signed-off-by: dependabot[bot] <[email protected]>
casibbald
force-pushed
the
dependabot/npm_and_yarn/mui-5d9b011568
branch
from
6765865 to
68db1dd
Compare
Bumps the mui group with 2 updates: @mui/icons-material and @mui/material.
Updates
@mui/icons-materialfrom 7.1.2 to 7.2.0Release notes
Sourced from
@mui/icons-material's releases.... (truncated)
Changelog
Sourced from
@mui/icons-material's changelog.... (truncated)
Commits
1496d737.2.0 (#46422)1b44e99Mergev7.1.2(#46435)45ffa70Bump@types/reactto ^19.1.8 (#46339)3939e18Bump babel to ^7.27.6 (#46289)d72b333Bump babel (#46245)Updates
@mui/materialfrom 7.1.2 to 7.2.0Release notes
Sourced from
@mui/material's releases.... (truncated)
Changelog
Sourced from
@mui/material's changelog.... (truncated)
Commits
1496d737.2.0 (#46422)1b44e99Mergev7.1.2(#46435)0d12e36[material-ui][OutlinedInput][Input] Deprecate composed classes (#46316)00e0374[l10] EnablelabelDisplayedRowstranslation for Romanian (#46377)9a4e8a8Bump@types/prop-typesto ^15.7.15 (#46338)45ffa70Bump@types/reactto ^19.1.8 (#46339)1252199[material-ui] Skip generatingmodularCssLayersCSS var (#46329)37d7020[system] AddmodularCssLayerstheme flag to split styles into multiple CSS ...3939e18Bump babel to ^7.27.6 (#46289)d13428c[core] Support merging of className and style from theme (#45975)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions